-
Notifications
You must be signed in to change notification settings - Fork 5
ENH: switching to JB2 infrastructure #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1aba9ba to
85238de
Compare
|
Currently there is one build error that produces an incorrect linking, reported it upstream, but we can also just work around it in the meantime by not linking to the figure anchor: jupyter-book/mystmd#2209 |
c50edd5 to
a898c26
Compare
89a4ed7 to
2e4a1f4
Compare
a75e5b3 to
2ebddd0
Compare
2ebddd0 to
8ff7349
Compare
|
@bsipocz if the JB2 stuff is still going to take awhile, can the TOC reorg go through separately? It would be really nice to get that published. |
|
The bad news is that while toc files can work with JB1 their content/syntax is a bit different. But I'll get back to this and try to get the build going on GHA to narrow down if it's a circle issue or not. |
35854d1 to
79e6c69
Compare
|
OK, so the cryptic build/kernel issue doesn't seem to effect GHA. It's really puzzling of what's going wrong on circleCI as why it is so undeterministic |
be14787 to
6c77ef2
Compare
6c77ef2 to
e8f017a
Compare
870e20d to
33cab0f
Compare
0430dcf to
0d9c758
Compare
6354afb to
cc4e231
Compare
|
I have hunted down the issue for the CI troubles: Our build is hovering at the total memory limit. Currently I have no control over the parallelism (turning it off is expected to help) nor have solutions to potentially run the new stack more efficiently. I do propose the current workaround:
So with all this being said, I think this PR is very close to be being ready, I'll fix up some more of the comments that you have given above and leave the remaining checkbox items as well as the longer-term items for follow-ups. |
troyraen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bsipocz this will be great! Please open an issue with three lists of notebooks:
- Excluded from rendering
- Excluded from testing in PRs
- Excluded from cron job testing
|
See #145 |
ENH: switching to JB2 infrastructure 8901b1e
Opening this PR so we only iterate on the TOC structure once.
TODOs blocking merge:
create a universal make file to make sure we use the same in all CI(and then easily reproduce locally) -- added to tox for nowjira: IRSA-7092
resolves #98 closes #123 resolves #124 resolves #140
Checklist from review: